feat: added extra translations for frontend-plugin-learner-dashboard#7
feat: added extra translations for frontend-plugin-learner-dashboard#7jajjibhai008 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds translation support for the frontend-plugin-learner-dashboard plugin by integrating it into the existing translation pipeline.
Key Changes:
- Introduced variable definitions (
ATLAS_EXTRA_SOURCESandATLAS_OPTIONS) to make translation sources more maintainable - Extended the
pull_translationstarget to include the new plugin's translation source - Added the plugin to the
intl_importscommand to process imported translations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
jajjibhai008
force-pushed
the
eahmadjaved/ENT-11106
branch
2 times, most recently
from
97e1ced to
49edb41
Compare
jajjibhai008
force-pushed
the
eahmadjaved/ENT-11106
branch
from
49edb41 to
e1dcad9
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
There was a problem hiding this comment.
The idea of making an $(ATLAS_EXTRA_SOURCES) a variable is so that this doesn't have to be a fork from upstream. So instead of using the variable but then hardcoding the repo on lines 16-17 and line 58, you should keep your line 56 here and have another variable on line 58 like $ATLAS_EXTRA_INTL_IMPORTS. That can go up to openedx so nobody needs to maintain a fork. Then you define the contents of those 2 variables, and the contents of ATLAS_OPTIONS, in edx-internal.
With this suggestion, we can actually have this change on the Open edX repository. Since there would be no hardcoded, 2U-specific code in the repo at that point. Doing it this way, we will avoid diverging from the master branch of Open edX and also making future updates less of a pain. So I would vote to point this PR to |
Description
Extends translation infrastructure to support frontend-plugin-learner-dashboard by adding it as a translation source in the Makefile's
pull_translationstarget. This enables the internationalization workflow to extract, manage, and import plugin-specific translatable strings from theedx/openedx-translationsrepository.